Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_log_analytics_datasource_windows_event #6321

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 1, 2020

This is one of the datasource requested by #3182.

Test Result:

> make testacc TEST=./azurerm/internal/services/loganalytics/tests TESTARGS="-run='TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/loganalytics/tests -v -run='TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete (257.83s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic (466.11s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport (504.55s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update (567.42s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/loganalytics/tests  567.465s

Fixes #3182

@mbfrahry mbfrahry self-assigned this Apr 1, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! With a minor note for the docs

@magodo magodo requested a review from mbfrahry April 2, 2020 04:50
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Log analytics workspace datasource windows event New Resource: azurerm_log_analytics_datasource_windows_event Apr 2, 2020
@mbfrahry mbfrahry merged commit 5c085ae into hashicorp:master Apr 2, 2020
@katbyte katbyte added this to the v2.4.0 milestone Apr 2, 2020
mbfrahry added a commit that referenced this pull request Apr 2, 2020
@ghost
Copy link

ghost commented Apr 2, 2020

This has been released in version 2.4.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.4.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Data Sources in a Log Analytics Workspace
3 participants