New Resource - azurerm_data_factory_linked_service_blob_[blob|storage|sfpt]

[markti]

Feature #4029
Feature #6365
Feature #6167
Feature #6413
Feature #6166

First time writing in golang, ever. First time contributor. Please be nice to me. :o)

W.r.t. the Web Linked service. I did not implement Basic / ClientCredential. Is that ok? Assuming I get everything working would it be included in the provider without all authentication types supported?

I have a problem with the acceptance tests. They fail on the data.ImportStep(). I was unable to test these resources because I'm unfamiliar with how to test a terraform provider plugin. When I run the acceptance tests, I see new resource groups / data factories provisioned in my Azure Subscription. I assume this means that the Data Factory / Linked Service deployed properly but maybe I am not loading the API response back into state properly. Any idea why I am getting these errors in Acceptance test?

A couple questions from a newbie:

1. is there a way to pause the acceptance tests so I can go manually inspect what was provisioned in Azure?
2. Alternatively, What's the best way to see the REST API calls that Terraform is making?

Thank you so much in advance!

Mark

(fixes #4029 fixes #6365 fixes #6167 fixes #6413 fixes #6166)

[katbyte]

Thanks for the new resources @markti!

Over all these look great and i've left some minor comments inline. In addition to these could we add documentation for the new resource? thanks!

[katbyte]

For any property that accepts capitals could we use some to ensure the api handles them correctly?

[katbyte]

For any property that accepts capitals could we use some to ensure the api handles them correctly?

[markti]

Thanks for the new resources @markti!

Over all these look great and i've left some minor comments inline. In addition to these could we add documentation for the new resource? thanks!

Thanks!
I’ll have to look at the readme about generating documentation. Any idea why I didn’t pass terrfmt? I had a question regarding authentication type if I could pick your brain there it would be helpful maybe I can include all three auth types. My golang is very fresh.

[katbyte]

@markti, documentation generation is still fairly new and most resources are written without it. You should be able to just copy some of the existing documentation and only have to make minor changes.

For terrafmt it could be a bunch of things, but you can just run it on the files listed in the output (or the entire provider) and it'll automatically fix it 🙂

And of course, i'm not sure what you mean by the authentication type? the parse function & id type? (also feel free to reach out to me on our community slack if you'd like - link in our readme)

[markti]

@katbyte sorry I made some updates to the code, some renaming of files which caused some of your feedback to become outdated.

[markti]

@markti, documentation generation is still fairly new and most resources are written without it. You should be able to just copy some of the existing documentation and only have to make minor changes.

For terrafmt it could be a bunch of things, but you can just run it on the files listed in the output (or the entire provider) and it'll automatically fix it 🙂

And of course, i'm not sure what you mean by the authentication type? the parse function & id type? (also feel free to reach out to me on our community slack if you'd like - link in our readme)

@katbyte I'm running terrafmt on the files

"terrafmt -f -v ./path/to/file.go" but it is telling me that "0/3 blocks need formatting"

[katbyte]

Thanks for those changes! aside from some files being renamed (which i will do now) this ltgm now 🙂

[ghost]

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!