Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_interface: expose internal_domain_name_suffix #6455

Merged

Conversation

bailsman
Copy link
Contributor

After a network interface has been created in a subnet, Azure assigns it
an internal domain name and exposes this as a property.

The suffix looks something like this:

tcjzv0sul21rwyt5qe31ylgpgo.ax.internal.cloudapp.net

Servers can reach each other internally at, for example:

server0.tcjzv0sul21rwyt5qe31ylgpgo.ax.internal.cloudapp.net

This change exposes the azure provided internal_domain_name_suffix in terraform.

This is useful, for example, when creating a self-signed server certificate to be used internally, if you do want the common name to match the hostname that the other server connects on.

@ghost ghost added the size/XS label Apr 13, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bailsman, thanks for the PR. overall this looks great but we're missing some doc updates. Whats those are done this should be good to merge!

After a network interface has been created in a subnet, Azure assigns it
an internal domain name and exposes this as a property.

The suffix looks something like this:

tcjzv0sul21rwyt5qe31ylgpgo.ax.internal.cloudapp.net

Servers can reach each other internally at, for example:

server0.tcjzv0sul21rwyt5qe31ylgpgo.ax.internal.cloudapp.net

This change exposes the azure provided internal_domain_name_suffix in terraform
@bailsman bailsman force-pushed the expose_internal_domain_name_suffix branch from 158ae1c to 628df55 Compare April 14, 2020 15:39
@ghost ghost added the documentation label Apr 14, 2020
@bailsman
Copy link
Contributor Author

Oops. I force pushed and may have disappeared your comments, so now I'm not sure what changes you requested. I added a line to the resource documentation explaining the attribute that is now exposed.

@bailsman bailsman requested a review from katbyte April 14, 2020 15:42
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bailsman! LGTM now 👍

@katbyte katbyte added this to the v2.6.0 milestone Apr 14, 2020
@katbyte katbyte merged commit 02c0bf7 into hashicorp:master Apr 14, 2020
katbyte added a commit that referenced this pull request Apr 14, 2020
@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants