Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway - per api requirements, public_ip_address_id is required #6548

Merged
merged 2 commits into from Apr 21, 2020

Conversation

Annonator
Copy link
Contributor

Changing public_ip_address_id from Optional to Required as it throws errors if you try deploying without Public IP Address.

Error Message:
Error Creating/Updating AzureRM Virtual Network Gateway "test" (Resource Group "test2"): network.VirtualNetworkGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="PublicIpForGatewayIsRequired" Message="Public IP address reference is required for gateway IP configration /subscriptions/SUBSCRIPTIONID/resourceGroups/test2/providers/Microsoft.Network/virtualNetworkGateways/test." Details=[]

on gatewayTest.tf line 26, in resource "azurerm_virtual_network_gateway" "example":
26: resource "azurerm_virtual_network_gateway" "example" {

Changing public_ip_address_id from Optional to Required as it throws errors if you try deploying without Public IP Address
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I went ahead and update the attribute tag to reflect the doc change as well

@mbfrahry mbfrahry changed the title updated public_ip_address_id to required azurerm_virtual_network_gateway - per api requirements, public_ip_address_id is required Apr 21, 2020
@mbfrahry mbfrahry merged commit 6995709 into hashicorp:master Apr 21, 2020
mbfrahry added a commit that referenced this pull request Apr 21, 2020
katbyte added a commit that referenced this pull request Apr 21, 2020
@ghost
Copy link

ghost commented May 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants