new resource "azurerm_automation_connection", azurerm_automation_connection_certificate, azurerm_automation_connection_classic_certificate and azurerm_automation_connection_service_pricipal`

[njuCZ]

automation account API does not provider run as account interface, users need to configure service principal, automation certificate and automation connection manually.
This is the last PR about the flow.

azurerm_automation_connection_certificate, azurerm_automation_connection_classic_certificate, azurerm_automation_connection_service_pricipal coresponds to
resource azurerm_automation_connection_certificate coresponds to builtin types: Azure, AzureClassicCertificate , AzureServicePrincipal.

azurerm_automation_connection is designed for connecting user's custom connection type. (user could add new types).

https://docs.microsoft.com/en-us/azure/automation/automation-connections#connection-types
https://docs.microsoft.com/en-us/azure/automation/automation-connections#add-a-connection-type

relevant issues
#4431
#3881

(fixes #3881)

[katbyte]

Thanks for this PR @njuCZ,

Overall this looks good, but i think it may be better to have three different resources for each type exposing the required properties for each?
azurerm_automation_connection_certificate, azurerm_automation_connection_classic_certificate, and azurerm_automation_connection_service_pricipal. WDYT?

[njuCZ]

@katbyte because the docs says user could add a custom connection type and required parameters. Creating a connection could choose user's custom connection type. So if we split them into three resources, I am afraid this feature could not be supported.

[katbyte]

@njuCZ - then could we create the three strongly typed resources and then this one can be used for user defined ones?

[njuCZ]

@katbyte ok, thanks for your suggestion

[njuCZ]

sorry for busy other things yesterday, I will update this PR as soon as possible

[njuCZ]

@katbyte I have updated the PR, please have a look

[lazywinadmin]

Any update on when this will be released ? @katbyte
It would be great to be able to create connection resources within Automation Account
Thanks

[katbyte]

Thanks for the changes @njuCZ, aside from some minor corrections which i've added as suggestions and will commit now - this LGTM 👍

[ghost]

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!