azurerm_app_service_slot - support application_logs.file_system

[sschmeck]

Fixes #7007

[katbyte]

Thanks for the pr @sschmeck - in addition to updating the docs maybe this would make more sense as file_system_level rather then a block for better ux and reduced complexity?

[katbyte]

as there doesn't seem to be any other configuration for file system would this be better as

Suggested change

	file_system {
	level = "Warning"
	}
	file_system_level = "Warning"

[katbyte]

thanks for the change @sschmeck - just need to update the docs and this will; be good to merge!

[jongio]

Here's a scenario that I want to make sure is supported.

1. User settings file_system_level to Warning, and puts this in their TF file:
   file_system_level = Warning
2. Time passes
3. User wants to turn it off.

User should be able to:

1. Remove file_system_level = Warning property altogether.
2. Set file_syste_level = Off

I'm assuming that the second option will work, but could you also test to see if the first option turns it off as well?

• Support: "Turn off file_system_level by omitting the property when file_system_level was previously set"

Thanks,
Jon

[katbyte]

@jongio that would require a default of off i think - @sschmeck does this default to off and would that make sense?

[sschmeck]

@katbyte Regarding the default value, I'm not sure it's necessary.

I would expect the logging is turned off, if nothing is set explicitly. But I'm not able to test it. I'm not familiar with that kind configuration of configuration. I tried to check the extracted ARM templates for a App Service in the Azure Portal but couln't find the setting in the extracted template. :/

In the Azure Portal where you setup the App Service logs view, there is a tooltip for the Application Logging (Filesystem) with the following tooltip - "Enable application logging to collect diagnostic traces from your web app code. You'll need to turn this on to enable the streaming log feature. This setting turns itself off after 12 hours."

Therefore the configuration seems not persistent.

[jongio]

LMK if you want me to test anything.

[katbyte]

Thanks @sschmeck - we can add the default later on if need be, and since its a temporary setting even easier. LGTM 👍

[jongio]

Thank you @sschmeck and @katbyte !

[ghost]

This has been released in version 2.21.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.21.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!