Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_machine_learning_workspace: fix acctests #7635

Merged
merged 4 commits into from Jul 10, 2020
Merged

azurerm_machine_learning_workspace: fix acctests #7635

merged 4 commits into from Jul 10, 2020

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented Jul 9, 2020 •
edited

The machine learning service has changed the delete from a sync operation to an async operation.

Depends on the SDK v44.0.0 PR #7616

@ghost ghost added the size/XXL label Jul 9, 2020
@ArcturusZhang ArcturusZhang added sdk/requires-upgrade This is dependent upon upgrading an SDK service/machine-learning labels Jul 9, 2020
katbyte
katbyte requested changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArcturusZhang - could we revert the SDK upgrade here? otherwise looks good reread description, my bad. we'll merge the SDK upgrade after the release today

@ghost ghost added size/XS and removed size/XXL labels Jul 10, 2020
katbyte
katbyte approved these changes Jul 10, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang, LGTM

@katbyte katbyte added this to the v2.19.0 milestone Jul 10, 2020
@katbyte katbyte added bug and removed sdk/requires-upgrade This is dependent upon upgrading an SDK labels Jul 10, 2020
@katbyte katbyte merged commit b7547ae into hashicorp:master Jul 10, 2020
katbyte added a commit that referenced this pull request Jul 10, 2020
@katbyte
update CHANGELOG.md for #7635
1e37be8
@ArcturusZhang ArcturusZhang deleted the fix-ml-tests branch July 11, 2020 05:07
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ArcturusZhang ArcturusZhang mentioned this pull request Jul 23, 2020
Closed
@ghost
Copy link

ghost commented Aug 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug service/machine-learning size/XS
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArcturusZhang @katbyte