Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_managed_disk - increase the maximum disk_size_gb to 65536 GB. #7689

Merged
merged 2 commits into from Jul 10, 2020

Conversation

jvinicius
Copy link
Contributor

@jvinicius jvinicius commented Jul 10, 2020

Azure Ultra SSD Managed Disk (storage_account_type UltraSSD_LRS) supports more than 32767 GB.

This code fix this limitation, allowing the max of 65536 for Ultra SSD.

Fixes #7672

@ghost ghost added the size/XS label Jul 10, 2020
@jvinicius jvinicius changed the title Increase Managed Disk Max Size to 65536 GB. Fix issue #7672 Increase Managed Disk Max Size to 65536 GB. Jul 10, 2020
@jvinicius
Copy link
Contributor Author

Fix issue #7672

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one minor comment this otherwise LGTM - thanks @jvinicius 👍

}
if value > 32767 {
warnings = append(warnings,
"The `disk_size_gb` can be higher than 32767 only for `storage_account_type` UltraSSDLRS")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whilst exposed in the SDK, unfortunately warnings don't work at this time - so could we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure. Thanks for you feedback.

Copy link
Contributor Author

@jvinicius jvinicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
if value > 32767 {
warnings = append(warnings,
"The `disk_size_gb` can be higher than 32767 only for `storage_account_type` UltraSSDLRS")
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure. Thanks for you feedback.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jvinicius! LGTM 👍

@katbyte katbyte changed the title Increase Managed Disk Max Size to 65536 GB. azurerm_managed_disk - increase the maximum disk_size_gb to 65536 GB. Jul 10, 2020
@jvinicius
Copy link
Contributor Author

Code updated, following @tombuildsstuff comment 👍

@ghost ghost removed the waiting-response label Jul 10, 2020
@katbyte katbyte merged commit ca1b683 into hashicorp:master Jul 10, 2020
katbyte added a commit that referenced this pull request Jul 10, 2020
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managed Disk disk_size_gb can only be between 0 and 32767
3 participants