New Resource: azurerm_data_factory_linked_service_azure_sql_database
#8349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
katbyte
reviewed
Sep 5, 2020
Comment on lines
149
to
164
| secureString := datafactory.SecureString{ | ||
| Value: &connectionString, | ||
| Type: datafactory.TypeSecureString, | ||
| } | ||
|
|
||
| sqlProperties := &datafactory.AzureSQLDatabaseLinkedServiceTypeProperties{ | ||
| ConnectionString: &secureString, | ||
| } | ||
|
|
||
| description := d.Get("description").(string) | ||
|
|
||
| azureSQLDatabaseLinkedService := &datafactory.AzureSQLDatabaseLinkedService{ | ||
| Description: &description, | ||
| AzureSQLDatabaseLinkedServiceTypeProperties: sqlProperties, | ||
| Type: datafactory.TypeAzureSQLDatabase, | ||
| } |
There was a problem hiding this comment.
minor and optional i'd prefer this to be
Suggested change
| secureString := datafactory.SecureString{ | |
| Value: &connectionString, | |
| Type: datafactory.TypeSecureString, | |
| } | |
| sqlProperties := &datafactory.AzureSQLDatabaseLinkedServiceTypeProperties{ | |
| ConnectionString: &secureString, | |
| } | |
| description := d.Get("description").(string) | |
| azureSQLDatabaseLinkedService := &datafactory.AzureSQLDatabaseLinkedService{ | |
| Description: &description, | |
| AzureSQLDatabaseLinkedServiceTypeProperties: sqlProperties, | |
| Type: datafactory.TypeAzureSQLDatabase, | |
| } | |
| azureSQLDatabaseLinkedService := &datafactory.AzureSQLDatabaseLinkedService{ | |
| Description: &util.string(d.Get("description").(string)),, | |
| AzureSQLDatabaseLinkedServiceTypeProperties: &datafactory.AzureSQLDatabaseLinkedServiceTypeProperties{ | |
| ConnectionString: &datafactory.SecureString{ | |
| Value: util.string(d.Get("connection_string").(string)), | |
| Type: datafactory.TypeSecureString, | |
| }, | |
| } | |
| Type: datafactory.TypeAzureSQLDatabase, | |
| } |
Comment on lines
264
to
270
| id, err := azure.ParseAzureResourceID(d.Id()) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| resourceGroup := id.ResourceGroup | ||
| dataFactoryName := id.Path["factories"] | ||
| name := id.Path["linkedservices"] |
There was a problem hiding this comment.
We should write a proper resource id parsing function here?
| resource.TestCheckResourceAttr(data.ResourceName, "description", "test description"), | ||
| ), | ||
| }, | ||
| { |
There was a problem hiding this comment.
should we include an import step here?
katbyte
approved these changes
Sep 5, 2020
mbfrahry
changed the title
azurerm_data_factory_linked_service_azure_sql_databaseazurerm_data_factory_linked_service_azure_sql_database
mbfrahry
added a commit
that referenced
this pull request
Sep 9, 2020
|
This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.27.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing tests