Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - ensure OMS Agent log analytics workspace case is preserved after disabling/enabling #8374

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Sep 7, 2020

AKS service will somehow ignore the config key cases after disable then enable the omsagent. Opened an issue to track this issue: Azure/azure-rest-api-specs#10716.

This PR is a workaround to unblock #8344.

@ghost ghost added the size/XS label Sep 7, 2020
@ghost ghost added size/M and removed size/XS labels Sep 9, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added bug service/kubernetes-cluster upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Sep 11, 2020
@katbyte katbyte changed the title aks omsagent config log analytics workspace case not kept after disabling/enabling azurerm_kubernetes_cluster - ensure OMS Agent log analytics workspace case is preserved after disabling/enabling Sep 13, 2020
@katbyte katbyte added this to the v2.28.0 milestone Sep 13, 2020
@katbyte katbyte merged commit f8c821e into hashicorp:master Sep 13, 2020
katbyte added a commit that referenced this pull request Sep 13, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/kubernetes-cluster size/M upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants