Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_eventhub_consumer_group - allow the name property to be set to $Default #8388

Merged
merged 7 commits into from Sep 13, 2020
Merged

azurerm_eventhub_consumer_group - allow the name property to be set to $Default #8388

merged 7 commits into from Sep 13, 2020

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Sep 8, 2020 •
edited

Fixes #7720

@ghost ghost added the size/XS label Sep 8, 2020
@ghost ghost added size/M and removed size/XS labels Sep 8, 2020
@favoretti
Copy link
Collaborator Author

@jackofallops would something like this work? Had to split validation for datasource and resource, to make sure people won't mangle $Default in resource definition.

@favoretti favoretti changed the title Add validation function for eventhub datasource to accept dollar sign Add validation function for EH consumer group datasource to accept dollar sign Sep 8, 2020
jackofallops
jackofallops requested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @favoretti
Thanks for this PR, I've had a quick look over and left one comment to look at initially since the new validation method regex would inadvertently allow invalid strings and not match $Default as intended.

Thanks!

azurerm/internal/services/eventhub/eventhub_consumer_group_data_source.go Outdated Show resolved Hide resolved
favoretti and others added 2 commits September 8, 2020 18:38
@favoretti @jackofallops
Update azurerm/internal/services/eventhub/eventhub_consumer_group_dat…
715eeba 
…a_source.go

Co-authored-by: Steve <11830746+jackofallops@users.noreply.github.com>
@favoretti
Remove extra function
98bb1f7
@ghost ghost added size/S and removed size/M labels Sep 8, 2020
@favoretti favoretti changed the title Add validation function for EH consumer group datasource to accept dollar sign Adjust validation for EH consumer group datasource to accept $Default Sep 8, 2020
@ghost ghost added size/M and removed size/S labels Sep 8, 2020
@neil-yechenwei
Copy link
Contributor

Address #7720

Please update the comment from "Address #7720" to "fixes #7720"

@ghost ghost removed the waiting-response label Sep 9, 2020
@favoretti
Copy link
Collaborator Author

@neil-yechenwei @jackofallops Feedback addressed.

katbyte
katbyte approved these changes Sep 13, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM now! 🚀

@katbyte katbyte added this to the v2.28.0 milestone Sep 13, 2020
@katbyte katbyte changed the title Adjust validation for EH consumer group datasource to accept $Default azurerm_eventhub_consumer_group - allow the name property to be set to $Default Sep 13, 2020
@katbyte katbyte merged commit c976891 into hashicorp:master Sep 13, 2020
katbyte added a commit that referenced this pull request Sep 13, 2020
@katbyte
update CHANGELOG.md for #8388
743311a
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neil-yechenwei neil-yechenwei neil-yechenwei left review comments

@katbyte katbyte katbyte approved these changes

@jackofallops jackofallops Awaiting requested review from jackofallops

Assignees
No one assigned
Labels
enhancement service/event-hubs EventHubs size/M
Projects
None yet
Milestone
v2.28.0
Development

Successfully merging this pull request may close these issues.

azurerm_eventhub_consumer_group doesn't support '$Default' consumer group name
4 participants
@favoretti @neil-yechenwei @katbyte @jackofallops