Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_policy_remediation - support resource_discovery_mode #9210

Merged

Conversation

ArcturusZhang
Copy link
Contributor

No description provided.

@ArcturusZhang
Copy link
Contributor Author

All tests have passed:

=== RUN   TestAccAzureRMPolicyRemediation_atSubscription
=== PAUSE TestAccAzureRMPolicyRemediation_atSubscription
=== CONT  TestAccAzureRMPolicyRemediation_atSubscription
--- PASS: TestAccAzureRMPolicyRemediation_atSubscription (228.45s)
=== RUN   TestAccAzureRMPolicyRemediation_atSubscriptionWithDefinitionSet
=== PAUSE TestAccAzureRMPolicyRemediation_atSubscriptionWithDefinitionSet
=== CONT  TestAccAzureRMPolicyRemediation_atSubscriptionWithDefinitionSet
--- PASS: TestAccAzureRMPolicyRemediation_atSubscriptionWithDefinitionSet (230.55s)
=== RUN   TestAccAzureRMPolicyRemediation_atResourceGroup
=== PAUSE TestAccAzureRMPolicyRemediation_atResourceGroup
=== CONT  TestAccAzureRMPolicyRemediation_atResourceGroup
--- PASS: TestAccAzureRMPolicyRemediation_atResourceGroup (274.17s)
=== RUN   TestAccAzureRMPolicyRemediation_atResourceGroupWithDiscoveryMode
=== PAUSE TestAccAzureRMPolicyRemediation_atResourceGroupWithDiscoveryMode
=== CONT  TestAccAzureRMPolicyRemediation_atResourceGroupWithDiscoveryMode
--- PASS: TestAccAzureRMPolicyRemediation_atResourceGroupWithDiscoveryMode (311.12s)
=== RUN   TestAccAzureRMPolicyRemediation_atManagementGroup
=== PAUSE TestAccAzureRMPolicyRemediation_atManagementGroup
=== CONT  TestAccAzureRMPolicyRemediation_atManagementGroup
--- PASS: TestAccAzureRMPolicyRemediation_atManagementGroup (281.24s)
=== RUN   TestAccAzureRMPolicyRemediation_atResource
=== PAUSE TestAccAzureRMPolicyRemediation_atResource
=== CONT  TestAccAzureRMPolicyRemediation_atResource
--- PASS: TestAccAzureRMPolicyRemediation_atResource (372.68s)
=== RUN   TestAccAzureRMPolicyRemediation_updateLocation
=== PAUSE TestAccAzureRMPolicyRemediation_updateLocation
=== CONT  TestAccAzureRMPolicyRemediation_updateLocation
--- PASS: TestAccAzureRMPolicyRemediation_updateLocation (398.75s)
=== RUN   TestAccAzureRMPolicyRemediation_requiresImport
=== PAUSE TestAccAzureRMPolicyRemediation_requiresImport
=== CONT  TestAccAzureRMPolicyRemediation_requiresImport
--- PASS: TestAccAzureRMPolicyRemediation_requiresImport (282.53s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang - LGTM 🚀

@katbyte katbyte merged commit 3cae546 into hashicorp:master Nov 9, 2020
katbyte added a commit that referenced this pull request Nov 9, 2020
@ArcturusZhang ArcturusZhang deleted the remediation-resource-discovery-mode branch November 10, 2020 00:45
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants