log_analytics_workspace - exclude Free from daily_quota_gb settings
#9228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
manicminer
requested changes
Nov 10, 2020
There was a problem hiding this comment.
@jackofallops LGTM, just a couple suggestions to account for case insensitivity
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
manicminer
approved these changes
Nov 10, 2020
jackofallops
force-pushed
the
b/log_analytics_quota_regression
branch
from
194c37a
to
5221d4c
Compare
katbyte
added a commit
that referenced
this pull request
Nov 10, 2020
|
This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.36.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Freetier SKU does not accept changes for the Quota value, and is always set to0.5GB.Upgrade Notes:
Previously the
daily_quota_gbargument on thelog_analytics_workspaceresource required setting to-1to disable. This is no longer a valid value and the argument should be removed to set to the default ofUnlimited.fixes #9150