Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cosmosdb_account - support for public_network_access_enabled #9236

Merged
merged 2 commits into from Nov 19, 2020
Merged

azurerm_cosmosdb_account - support for public_network_access_enabled #9236

merged 2 commits into from Nov 19, 2020

Conversation

petems
Copy link
Contributor

@petems petems commented Nov 10, 2020

@petems petems force-pushed the add_public_network_access_to_cosmosdb branch 3 times, most recently from 7204d24 to dde8391 Compare November 10, 2020 16:15
@petems petems force-pushed the add_public_network_access_to_cosmosdb branch from dde8391 to 48474aa Compare November 10, 2020 16:45
katbyte
katbyte approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @petems - LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.37.0 milestone Nov 19, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.37.0, v2.38.0 Nov 19, 2020
katbyte
katbyte approved these changes Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @petems - this LGTM 👍

@katbyte katbyte changed the title Adds PublicNetworkAccess parameter to Cosmosdb azurerm_cosmosdb_account - support for public_network_access_enabled Nov 19, 2020
@katbyte katbyte modified the milestones: v2.38.0, v2.37.0 Nov 19, 2020
@katbyte katbyte merged commit d620b7e into hashicorp:master Nov 19, 2020
katbyte added a commit that referenced this pull request Nov 19, 2020
@katbyte
update CHANGELOG.md for #9236
700ddf3
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@petems petems deleted the add_public_network_access_to_cosmosdb branch November 20, 2020 09:17
@ghost
Copy link

ghost commented Dec 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/cosmosdb size/M
Projects
None yet
Milestone
v2.37.0
Development

Successfully merging this pull request may close these issues.

Support for PublicNetworkAccess property flag on resource azurerm_cosmosdb_account
3 participants
@petems @katbyte @tombuildsstuff