Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added avset name validation #9279

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

ritesh-modi
Copy link
Contributor

Name validation for compute avset resource was missing. added it.

TF_ACC=1 go test -v ./azurerm/internal/services/compute/tests/ -run=TestAccAzureRMAvailabilitySet -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMAvailabilitySet_basic
=== PAUSE TestAccAzureRMAvailabilitySet_basic
=== RUN TestAccAzureRMAvailabilitySet_requiresImport
=== PAUSE TestAccAzureRMAvailabilitySet_requiresImport
=== RUN TestAccAzureRMAvailabilitySet_disappears
=== PAUSE TestAccAzureRMAvailabilitySet_disappears
=== RUN TestAccAzureRMAvailabilitySet_withTags
=== PAUSE TestAccAzureRMAvailabilitySet_withTags
=== RUN TestAccAzureRMAvailabilitySet_withPPG
=== PAUSE TestAccAzureRMAvailabilitySet_withPPG
=== RUN TestAccAzureRMAvailabilitySet_withDomainCounts
=== PAUSE TestAccAzureRMAvailabilitySet_withDomainCounts
=== RUN TestAccAzureRMAvailabilitySet_unmanaged
=== PAUSE TestAccAzureRMAvailabilitySet_unmanaged
=== CONT TestAccAzureRMAvailabilitySet_basic
=== CONT TestAccAzureRMAvailabilitySet_withPPG
=== CONT TestAccAzureRMAvailabilitySet_withDomainCounts
=== CONT TestAccAzureRMAvailabilitySet_requiresImport
=== CONT TestAccAzureRMAvailabilitySet_disappears
=== CONT TestAccAzureRMAvailabilitySet_withTags
=== CONT TestAccAzureRMAvailabilitySet_unmanaged
--- PASS: TestAccAzureRMAvailabilitySet_disappears (84.74s)
--- PASS: TestAccAzureRMAvailabilitySet_withDomainCounts (88.39s)
--- PASS: TestAccAzureRMAvailabilitySet_basic (89.28s)
--- PASS: TestAccAzureRMAvailabilitySet_unmanaged (90.43s)
--- PASS: TestAccAzureRMAvailabilitySet_withPPG (95.31s)
--- PASS: TestAccAzureRMAvailabilitySet_requiresImport (96.65s)
--- PASS: TestAccAzureRMAvailabilitySet_withTags (114.65s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute/tests 114.717s

@ghost ghost added the size/XS label Nov 12, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @ritesh-modi

@tombuildsstuff tombuildsstuff added this to the v2.36.0 milestone Nov 12, 2020
@tombuildsstuff tombuildsstuff merged commit 98a4f14 into hashicorp:master Nov 12, 2020
tombuildsstuff added a commit that referenced this pull request Nov 12, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants