Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_media_job #9859

Merged
merged 11 commits into from Dec 17, 2020
Merged

New resource: azurerm_media_job #9859

merged 11 commits into from Dec 17, 2020

Conversation

jcanizalez
Copy link
Contributor

Hi there introducing the support for new resource azurerm_media_job. This PR resolves #9786

Checked:

  • Update Documentation
  • Add new Acceptance Test and verified that the tests pass successfully
  • Check linting

@katbyte katbyte added this to the v2.41.0 milestone Dec 16, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - overall this looks good. Just a couple comments i've left inline to address before merge!

azurerm/internal/services/media/media_job_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/media_job_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/media_job_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/media_job_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/media_job_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/media_job_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/media_job_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/media_job_resource_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/media/media_job_resource_test.go Outdated Show resolved Hide resolved
@jcanizalez
Copy link
Contributor Author

thanks for your suggestions @katbyte :) I did the changes, when you have chance please take a look.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez

I hope you don't mind, I've pushed a couple minor changes so I can run the tests and hopefully merge this today 👍

@jackofallops
Copy link
Member

Acctests passing:
image

@jackofallops jackofallops merged commit ee189f0 into hashicorp:master Dec 17, 2020
jackofallops added a commit that referenced this pull request Dec 17, 2020
@ghost
Copy link

ghost commented Dec 17, 2020

This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.41.0"
}
# ... other configuration ...

@jcanizalez jcanizalez deleted the azurerm_media_job branch December 23, 2020 15:28
@ghost
Copy link

ghost commented Jan 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Jobs in Azure Media Services Account
3 participants