Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: create virtual hub connection configuration resource #13733

Conversation

josh-barker
Copy link
Contributor

@josh-barker josh-barker commented Oct 14, 2021

This PR is a work in progress.

It implements option 1 - A routing configuration resource - as a potential solution to the issue #11169

It is working quite well.

Currently, there's 1 bug where the update test will pass, but the actual connection in Azure isn't updated.

@josh-barker josh-barker marked this pull request as draft October 14, 2021 06:16
@josh-barker josh-barker force-pushed the feat/vhub-connection-configuration branch from fd2670f to 01d8494 Compare October 14, 2021 06:49
@josh-barker josh-barker force-pushed the feat/vhub-connection-configuration branch from 01d8494 to d73614c Compare October 14, 2021 07:13
@josh-barker
Copy link
Contributor Author

Closing PR as per design discussion with @tombuildsstuff

#13743 replaces this PR.

@josh-barker josh-barker deleted the feat/vhub-connection-configuration branch October 21, 2021 23:13
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant