Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helpers: fixing test failures #1431

Merged
merged 2 commits into from
Jun 24, 2018
Merged

Helpers: fixing test failures #1431

merged 2 commits into from
Jun 24, 2018

Commits on Jun 22, 2018

  1. Fixing failing tests 

    ```
$ go test -v .
=== RUN   TestHelper_Validate_Ip4Address
--- PASS: TestHelper_Validate_Ip4Address (0.00s)
=== RUN   TestHelper_Validate_MacAddress
--- PASS: TestHelper_Validate_MacAddress (0.00s)
=== RUN   TestHelper_Validate_RFC3339Time
--- PASS: TestHelper_Validate_RFC3339Time (0.00s)
=== RUN   TestHelper_Validate_Rfc3339DateInFutureBy
--- PASS: TestHelper_Validate_Rfc3339DateInFutureBy (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.026s
```
    @tombuildsstuff
    tombuildsstuff committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    40d252f View commit details
    Browse the repository at this point in the history

  2. Switching to use Go's built-in IPv4 parsing function 

    ```
$ go test -v ./azurerm/helpers/validate/
=== RUN   TestHelper_Validate_Ip4Address
--- PASS: TestHelper_Validate_Ip4Address (0.00s)
=== RUN   TestHelper_Validate_MacAddress
--- PASS: TestHelper_Validate_MacAddress (0.00s)
=== RUN   TestHelper_Validate_RFC3339Time
--- PASS: TestHelper_Validate_RFC3339Time (0.00s)
=== RUN   TestHelper_Validate_Rfc3339DateInFutureBy
--- PASS: TestHelper_Validate_Rfc3339DateInFutureBy (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate	0.027s
```
    @tombuildsstuff
    tombuildsstuff committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    9033eaf View commit details
    Browse the repository at this point in the history