Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKS: NetworkProfile / Advanced Networking #1479

Merged
merged 37 commits into from
Jul 25, 2018
Merged

AKS: NetworkProfile / Advanced Networking #1479

merged 37 commits into from
Jul 25, 2018

Commits on Jul 2, 2018

  1. Added kubernetes_cluster advanced network creation

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    5865322 View commit details
    Browse the repository at this point in the history

  2. Changed network_profile from TypeSet to TypeList

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    305c1d0 View commit details
    Browse the repository at this point in the history

  3. Added kubernetes_cluster advanced network creation

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    df237b2 View commit details
    Browse the repository at this point in the history

  4. Changed network_profile from TypeSet to TypeList

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    e3ec37e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'containerservices-advancednetworking' of https://github… 

    ….com/lfshr/terraform-provider-azurerm into containerservices-advancednetworking
    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    a3ff5b0 View commit details
    Browse the repository at this point in the history

  6. Updated ForceNew attributes on kubernetes_cluster.network_profile params

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    b7d274b View commit details
    Browse the repository at this point in the history

  7. Added advanced network read functionality

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    11bed67 View commit details
    Browse the repository at this point in the history

  8. Added tests for kubernetes_cluster.network_profile

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    30f39ff View commit details
    Browse the repository at this point in the history

  9. Fixed indentations

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    195e7d6 View commit details
    Browse the repository at this point in the history

  10. Fixed function name in tests

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    f8f5626 View commit details
    Browse the repository at this point in the history

  11. Fixed property name in test

    @lfshr
    lfshr committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    25c6e6e View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2018

  1. Fixed variable name

    @lfshr
    lfshr committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    48cff90 View commit details
    Browse the repository at this point in the history

  2. working on data source for kubernetes cluster

    @lfshr
    lfshr committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    2dd887c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'containerservices-advancednetworking' of https://github… 

    ….com/lfshr/terraform-provider-azurerm into containerservices-advancednetworking
    @lfshr
    lfshr committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    1bdf8b6 View commit details
    Browse the repository at this point in the history

  4. Fixed issue with datasource not working

    @lfshr
    lfshr committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    33c84c6 View commit details
    Browse the repository at this point in the history

  5. Added network_policy and fixed read

    @lfshr
    lfshr committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    f9786e1 View commit details
    Browse the repository at this point in the history

  6. Removed network_policy as unsupported

    @lfshr
    lfshr committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    02b22e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2018

  1. Added example of advanced networking

    @lfshr
    lfshr committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    b62a643 View commit details
    Browse the repository at this point in the history

  2. Added test for data_source

    @lfshr
    lfshr committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    377c52f View commit details
    Browse the repository at this point in the history

  3. Made address space more sensible

    @lfshr
    lfshr committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    7453f41 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2018

  1. Removing kubenet test. 

    This is default when network_profile is not specified.
We already test this.
    @lfshr
    lfshr committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    c90ea55 View commit details
    Browse the repository at this point in the history

  2. Made network_plugin a mandatory field. 

    Better to make this explicit.
    @lfshr
    lfshr committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    16e7d3e View commit details
    Browse the repository at this point in the history

  3. Updated documentation to include network_profile

    @lfshr
    lfshr committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    675d0b9 View commit details
    Browse the repository at this point in the history

  4. Fixing the build

    @tombuildsstuff
    tombuildsstuff committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    7c21183 View commit details
    Browse the repository at this point in the history

  5. Added ForceNew to network_profile

    @lfshr
    lfshr committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    1959c2f View commit details
    Browse the repository at this point in the history

  6. Made the docs a little clearer

    @lfshr
    lfshr committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    518cacc View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Documenting a required field

    @tombuildsstuff
    tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    9faeb69 View commit details
    Browse the repository at this point in the history

  2. Rephrasing the data sources

    @tombuildsstuff
    tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    1ef6ccf View commit details
    Browse the repository at this point in the history

  3. Making the network_profile block computed 

    Tests pass:

```
$ acctests azurerm TestAccAzureRMKubernetesCluster_basic
=== RUN   TestAccAzureRMKubernetesCluster_basic
--- PASS: TestAccAzureRMKubernetesCluster_basic (1329.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1329.613s
```
    @tombuildsstuff
    tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    dac7913 View commit details
    Browse the repository at this point in the history

  4. Fixing the field we're asserting on

    @tombuildsstuff
    tombuildsstuff committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    48d5ed7 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2018

  1. Conditionally expanding the network_profile block. 

    The ip fields are now Computed too
    @tombuildsstuff
    tombuildsstuff committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    a54aa89 View commit details
    Browse the repository at this point in the history

  2. Validation to ensure that a Subnet ID is assigned to the cluster when… 

    … the network_profile blocks specified

Example:

```

Error: Error running plan: 1 error(s) occurred:

* azurerm_kubernetes_cluster.test: 1 error(s) occurred:

* azurerm_kubernetes_cluster.test: If a `network_profile` block is specified, the Agent Pools must be attached to a Subnet

```
    @tombuildsstuff
    tombuildsstuff committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    9e862eb View commit details
    Browse the repository at this point in the history

  3. Updating the documentation to mention the new behaviour

    @tombuildsstuff
    tombuildsstuff committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    f2219c5 View commit details
    Browse the repository at this point in the history

  4. Adding independent tests for Kubenet and Azure networking profiles

    @tombuildsstuff
    tombuildsstuff committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    8a23d24 View commit details
    Browse the repository at this point in the history

  5. Conditional validation of the docker_bridge_cidr, dns_service_ip … 

    …and `service_cidr` fields.
    @tombuildsstuff
    tombuildsstuff committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    8d08c53 View commit details
    Browse the repository at this point in the history

  6. Updating the docs

    @tombuildsstuff
    tombuildsstuff committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    a72f105 View commit details
    Browse the repository at this point in the history

  7. Fixing the tests

    @tombuildsstuff
    tombuildsstuff committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    ff3e206 View commit details
    Browse the repository at this point in the history