POC: role management policy resource

[josh-barker]

This PR is a POC to create a resource for managing role management policy.

It's worth noting that the Azure API requires an ID and Description for user and group approvers.
The Azure API does not validate the description, so you could enter foo bar that will be presented in the Azure Portal.
If an empty string is set, nothing is shown in the Azure Portal.

Currently, the Vendor Dependencies check failure is expected as I needed to modify the vendored copy of the authorization API to get this functionality to work.

See:

• https://github.com/josh-barker/terraform-provider-azurerm/blob/feat/role-management-policy/vendor/github.com/hashicorp/go-azure-sdk/resource-manager/authorization/2020-10-01/rolemanagementpolicies/method_listforscope_autorest.go#L42-L82
• https://github.com/josh-barker/terraform-provider-azurerm/blob/feat/role-management-policy/vendor/github.com/hashicorp/go-azure-sdk/resource-manager/authorization/2020-10-01/rolemanagementpolicies/model_rolemanagementpolicyrule.go#L15-L38

Related issues with the SDK:

• Issue with Authorization / Role Management Policies / API Version 2020-10-01 go-azure-sdk#288
• Issue with Authorization / Role Management Policies / API Version 2020-10-01 go-azure-sdk#287

[jackofallops]

Hi @josh-barker
Thanks for this contribution. Given this PR is still in draft and hasn't been updated in some time, I'm going to close it for the time being to help us have a clearer picture of active work. We can re-open at a later date as needed, if/when there's progress that can be made.

Thanks again.

[josh-barker]

Hey @jackofallops ,

Thanks for your explanation. The way I was thinking about it was keeping it in draft until Tom comes back with some feedback, as this PR requires more thought and changes in the sdk generator, etc.

I'm keen to get feedback on this.
I'm wondering if you can re-open it and I can set it to not a draft?

Thanks!

[pchanvallon]

Hello @jackofallops and @josh-barker, really looking forward using this new resource, it is the missing piece to deploy a proper PIM configuration using Terraform. Many thanks for handling this subject.

[mark-adams]

Hi @josh-barker / @jackofallops,

Are there any plans to re-open this PR?

Like other commenters, we have an interest in seeing role management policy resources so we can use Azure PIM in our environment.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.