azurerm_pim_eligible_role_assignment: use timeout from ctx instead of a fix value
#22682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
requested changes
Jul 26, 2023
| @@ -653,3 +653,10 @@ func deleteEligibilityRoleAssignmentSchedule(ctx context.Context, client *roleel | |||
| return result, "Deleted", nil | |||
| } | |||
| } | |||
|
|
|||
| func waitTimeoutFromCtx(ctx context.Context, defaultValue time.Duration) time.Duration { | |||
There was a problem hiding this comment.
this default value will never get used - ctx's should always be wrapped by a timeout, so can we remove this method and instead use:
deadline, ok := ctx.Deadline()
if !ok {
return fmt.Errorf("internal-error: context had no deadline")
}
// ...
Timeout: time.Until(deadline),There was a problem hiding this comment.
that makes seanse. updated in this way.
1 task
tombuildsstuff
approved these changes
Jul 26, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may fixes #22588