Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_netapp_pool - update the validation of size_in_tb #22943

Merged
merged 3 commits into from
Aug 17, 2023
Merged

azurerm_netapp_pool - update the validation of size_in_tb #22943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af451ea
azurerm_netapp_pool - update the validation of size_in_tb
neil-yechenwei Aug 15, 2023
183afcc
update code
neil-yechenwei Aug 16, 2023
5090975
update code
neil-yechenwei Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/services/netapp/netapp_pool_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func resourceNetAppPool() *pluginsdk.Resource {
"size_in_tb": {
Type: pluginsdk.TypeInt,
Required: true,
ValidateFunc: validation.IntBetween(4, 500),
ValidateFunc: validation.IntBetween(2, 500),
},

"qos_type": {
Expand Down
4 changes: 2 additions & 2 deletions internal/services/netapp/netapp_pool_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func TestAccNetAppPool_update(t *testing.T) {
Config: r.basic(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("size_in_tb").HasValue("4"),
check.That(data.ResourceName).Key("size_in_tb").HasValue("2"),
check.That(data.ResourceName).Key("tags.%").HasValue("1"),
check.That(data.ResourceName).Key("qos_type").HasValue("Auto"),
),
Expand Down Expand Up @@ -147,7 +147,7 @@ resource "azurerm_netapp_pool" "test" {
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
service_level = "Standard"
size_in_tb = 4
size_in_tb = 2

tags = {
"CreatedOnDate" = "2022-07-08T23:50:21Z",
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/netapp_pool.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ The following arguments are supported:

* `service_level` - (Required) The service level of the file system. Valid values include `Premium`, `Standard`, or `Ultra`. Changing this forces a new resource to be created.

* `size_in_tb` - (Required) Provisioned size of the pool in TB. Value must be between `4` and `500`.
* `size_in_tb` - (Required) Provisioned size of the pool in TB. Value must be between `2` and `500`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a note here to clarify that this is a preview? (referencing the note on https://learn.microsoft.com/en-us/azure/azure-netapp-files/azure-netapp-files-set-up-capacity-pool)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.


* `qos_type` - (Optional) QoS Type of the pool. Valid values include `Auto` or `Manual`.

Expand Down