`azurerm_dns_cname_record`: try normalize `target_resource_id` with RecordTypeID before set to state #24181

wuxu92 · 2023-12-11T08:00:21Z

There is a nother API casing issue related to this resource: Azure/azure-rest-api-specs#6641 so change the acctest resource group name to lower case to make the acc test work.

stephybun · 2023-12-11T15:34:00Z

internal/services/dns/dns_cname_record_resource.go

@@ -192,7 +192,7 @@ func resourceDnsCNameRecordRead(d *pluginsdk.ResourceData, meta interface{}) err
 			if props.TargetResource != nil && props.TargetResource.Id != nil {
 				targetResourceId = *props.TargetResource.Id
 			}
-			d.Set("target_resource_id", targetResourceId)
+			d.Set("target_resource_id", normalizeTargetResourceID(targetResourceId))


We're only calling this once so it doesn't need to be a separate function. Can you please in-line the ID parsing above. We should also be raising the error from the parser instead of silently ignoring.

Sure! Updated.

stephybun · 2023-12-12T07:48:10Z

internal/services/dns/dns_cname_record_resource.go

+				if parsedID, err := recordsets.ParseRecordTypeIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = parsedID.ID()
+				}


@wuxu92 We still need to return the error here since we're expecting a record type ID. If the service suddenly begins returning an ID of a completely different type we would never know.

Suggested change

if parsedID, err := recordsets.ParseRecordTypeIDInsensitively(targetResourceId); err == nil {

targetResourceId = parsedID.ID()

}

parsedID, err := recordsets.ParseRecordTypeIDInsensitively(targetResourceId)

if err != nil {

return err

}

targetResourceId = parsedID.ID()

There is no document stating that the target resource ID must be a DNS record type ID. As far as I understand, it can refer to other Azure resources.

Hi @wuxu92 - I don't think this is the correct way to handle the reported issue. The target ref is intended for only a handful of resource types:

I think the user should be using record not target_resource_id in the configuration? Can you try a repro that way to see if the issue is resolved that way? Since the record property is supposed to be another DNS record, this would be a more stable place to work with any casing mitigations if they are still required.

Thanks @jackofallops I have repro with record field and it works well! FWIW should we still normalize the target_resource_id as we can with all these possible resource types?

stephybun

Thanks @wuxu92. This is almost good to go, could you please take a look at the latest comment?

stephybun · 2024-01-22T16:01:33Z

internal/services/dns/dns_cname_record_resource.go

+				if recordTypeID, err := recordsets.ParseRecordTypeIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = recordTypeID.ID()
+				} else if trafficManagerID, err := endpoints.ParseEndpointTypeIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = trafficManagerID.ID()
+				} else if cdnID, err := cdn.EndpointIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = cdnID.ID()
+				} else if frontDoorID, err := frontdoor.FrontendEndpointIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = frontDoorID.ID()
+				}


We're still silently ignoring the case where the returned ID is none of those resource types. We should error if the resource type isn't any of these.

If the resource type is not listed, we should directly use the ID from the API response. This could indicate an API bug or a new resource type supported by the API. Neither of these scenarios should disrupt client behavior, as far as I understand it.

I needed to check internally but you're right @wuxu92, apologies!

I did push a commit to add a comment above this logic linking to a piece of work we're doing on dynamic resource IDs - once that functionality is available we should be able to update this.

tombuildsstuff · 2024-01-24T15:46:39Z

x-ref to the recaser in: hashicorp/go-azure-helpers#189

…rk is finished

stephybun

Thanks @wuxu92 LGTM 👍

stephybun · 2024-01-25T15:44:26Z

internal/services/dns/dns_cname_record_resource.go

+				if recordTypeID, err := recordsets.ParseRecordTypeIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = recordTypeID.ID()
+				} else if trafficManagerID, err := endpoints.ParseEndpointTypeIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = trafficManagerID.ID()
+				} else if cdnID, err := cdn.EndpointIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = cdnID.ID()
+				} else if frontDoorID, err := frontdoor.FrontendEndpointIDInsensitively(targetResourceId); err == nil {
+					targetResourceId = frontDoorID.ID()
+				}


I needed to check internally but you're right @wuxu92, apologies!

I did push a commit to add a comment above this logic linking to a piece of work we're doing on dynamic resource IDs - once that functionality is available we should be able to update this.

…ecordTypeID before set to state (hashicorp#24181) * try normalize dns target resource id to fix case issue * use lowercase resource group name to fix acc tests * inline normalize target resource id * add other possible resource id for target resource id * add todo comment for updating the id parser logic once the recaser work is finished --------- Co-authored-by: Steph <steph@hashicorp.com>

…18761 hashicorp#24291

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.89.0" to "3.90.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.90.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.90.0
UPGRADE NOTES:

* provider - The provider will now automatically register the `AppConfiguration`, `DataFactory`, and `SignalRService` Resource Providers. When running Terraform with limited permissions, note that you [must disable automatic Resource Provider Registration and ensure that any Resource Providers Terraform requires are registered]([XXX](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration)). ([#24645](https://github.com/hashicorp/terraform-provider-azurerm/issues/24645))
 
FEATURES:

* **New Data Source**: `azurerm_nginx_configuration` ([#24642](https://github.com/hashicorp/terraform-provider-azurerm/issues/24642))
* **New Data Source**: `azurerm_virtual_desktop_workspace` ([#24732](https://github.com/hashicorp/terraform-provider-azurerm/issues/24732))
* **New Resource**: `azurerm_kubernetes_fleet_update_strategy` ([#24328](https://github.com/hashicorp/terraform-provider-azurerm/issues/24328))
* **New Resource**: `azurerm_site_recovery_vmware_replicated_vm` ([#22477](https://github.com/hashicorp/terraform-provider-azurerm/issues/22477))
* **New Resource**: `azurerm_spring_cloud_new_relic_application_performance_monitoring` ([#24699](https://github.com/hashicorp/terraform-provider-azurerm/issues/24699))

ENHANCEMENTS:

* provider: registering the Resource Provider `Microsoft.AppConfiguration` ([#24645](https://github.com/hashicorp/terraform-provider-azurerm/issues/24645))
* provider: registering the Resource Provider `Microsoft.DataFactory` ([#24645](https://github.com/hashicorp/terraform-provider-azurerm/issues/24645))
* provider: registering the Resource Provider `Microsoft.SignalRService` ([#24645](https://github.com/hashicorp/terraform-provider-azurerm/issues/24645))
* provider: the Provider is now built using Go 1.21.6 ([#24653](https://github.com/hashicorp/terraform-provider-azurerm/issues/24653))
* dependencies: the dependency `github.com/hashicorp/go-azure-sdk` has been split into multiple Go Modules - and as such will be referred to by those paths going forwards ([#24636](https://github.com/hashicorp/terraform-provider-azurerm/issues/24636))
* dependencies: updating to ``v0.20240201.1064937` of `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24738](https://github.com/hashicorp/terraform-provider-azurerm/issues/24738))
* dependencies: updating to `v0.20240201.1064937` of `github.com/hashicorp/go-azure-sdk/sdk` ([#24738](https://github.com/hashicorp/terraform-provider-azurerm/issues/24738))
* `appservice`: update to `go-azure-sdk` and API version `2023-01-01` ([#24688](https://github.com/hashicorp/terraform-provider-azurerm/issues/24688))
* `datafactory`: updating to use `tombuildsstuff/kermit` ([#24675](https://github.com/hashicorp/terraform-provider-azurerm/issues/24675))
* `hdinsight`: refactoring to use `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24011](https://github.com/hashicorp/terraform-provider-azurerm/issues/24011))
* `hdinsight`: updating to API Version `2021-06-01` ([#24011](https://github.com/hashicorp/terraform-provider-azurerm/issues/24011))
* `loadbalancer`: updating to use `hashicorp/go-azure-sdk` ([#24291](https://github.com/hashicorp/terraform-provider-azurerm/issues/24291))
* `nginx`: updating to API Version `2023-09-01` ([#24640](https://github.com/hashicorp/terraform-provider-azurerm/issues/24640))
* `servicefabricmanagedcluster`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24654](https://github.com/hashicorp/terraform-provider-azurerm/issues/24654))
* `springcloud`: updating to use API Version `2023-11-01-preview` ([#24690](https://github.com/hashicorp/terraform-provider-azurerm/issues/24690))
* `subscriptions`: refactoring to use `hashicorp/go-azure-sdk` ([#24663](https://github.com/hashicorp/terraform-provider-azurerm/issues/24663))
* Data Source: `azurerm_stream_analytics_job` - support for User Assigned Identities ([#24738](https://github.com/hashicorp/terraform-provider-azurerm/issues/24738))
* `azurerm_cosmosdb_account` - support for the `gremlin_database` and `tables_to_restore` properties ([#24627](https://github.com/hashicorp/terraform-provider-azurerm/issues/24627))
* `azurerm_bot_channel_email` - support for the `magic_code` property ([#23129](https://github.com/hashicorp/terraform-provider-azurerm/issues/23129))
* `azurerm_cosmosdb_account` - support for the `partition_merge_enabled` property ([#24615](https://github.com/hashicorp/terraform-provider-azurerm/issues/24615))
* `azurerm_mssql_managed_database` - support for the `immutable_backups_enabled` property ([#24745](https://github.com/hashicorp/terraform-provider-azurerm/issues/24745))
* `azurerm_mssql_database` - support for the `immutable_backups_enabled` property ([#24745](https://github.com/hashicorp/terraform-provider-azurerm/issues/24745))
* `azurerm_palo_alto_next_generation_firewall_virtual_hub_panorama` - support for the `trusted_address_ranges` property ([#24459](https://github.com/hashicorp/terraform-provider-azurerm/issues/24459))
* `azurerm_palo_alto_next_generation_firewall_virtual_network_local_rulestack` - support for the `trusted_address_ranges` property ([#24459](https://github.com/hashicorp/terraform-provider-azurerm/issues/24459))
* `azurerm_palo_alto_next_generation_firewall_virtual_network_panorama` - support for the `trusted_address_ranges` property ([#24459](https://github.com/hashicorp/terraform-provider-azurerm/issues/24459))
* `azurerm_servicebus_namespace` - updating to use API Version `2022-10-01-preview` ([#24650](https://github.com/hashicorp/terraform-provider-azurerm/issues/24650))
* `azurerm_spring_cloud_api_portal` - support for the `api_try_out_enabled` property ([#24696](https://github.com/hashicorp/terraform-provider-azurerm/issues/24696))
* `azurerm_spring_cloud_gateway` - support for the `local_response_cache_per_route` and `local_response_cache_per_instance` properties ([#24697](https://github.com/hashicorp/terraform-provider-azurerm/issues/24697))
* `azurerm_stream_analytics_job` - support for User Assigned Identities ([#24738](https://github.com/hashicorp/terraform-provider-azurerm/issues/24738))
* `azurerm_subscription` - refactoring to use `hashicorp/go-azure-sdk` to set tags on the subscription ([#24734](https://github.com/hashicorp/terraform-provider-azurerm/issues/24734))
* `azurerm_virtual_desktop_workspace` - correctly validate the `name` property ([#24668](https://github.com/hashicorp/terraform-provider-azurerm/issues/24668))


BUG FIXES:

* provider: skip registration for resource providers that are unavailable ([#24571](https://github.com/hashicorp/terraform-provider-azurerm/issues/24571))
* `azurerm_app_configuration` - no longer require `lifecycle_ignore_changes` for the `value` property when using a key vault reference ([#24702](https://github.com/hashicorp/terraform-provider-azurerm/issues/24702))
* `azurerm_app_service_managed_certificate` - fix casing issue in `app_service_plan_id` by parsing insensitively ([#24664](https://github.com/hashicorp/terraform-provider-azurerm/issues/24664))
* `azurerm_cognitive_deployment` - updates now include the `version` property ([#24700](https://github.com/hashicorp/terraform-provider-azurerm/issues/24700))
* `azurerm_dns_cname_record` - prevent casing issue in `target_resource_id` by parsing the ID insensitively ([#24181](https://github.com/hashicorp/terraform-provider-azurerm/issues/24181))
* `azurerm_mssql_managed_instance_failover_group` - prevent an issue when trying to create a failover group with a managed instance from a different subscription ([#24646](https://github.com/hashicorp/terraform-provider-azurerm/issues/24646))
* `azurerm_storage_account` - conditionally update properties only when needed ([#24669](https://github.com/hashicorp/terraform-provider-azurerm/issues/24669))
* `azurerm_storage_account` - change update order for `access_tier`to prevent errors when uploading blobs to the archive tier ([#22250](https://github.com/hashicorp/terraform-provider-azurerm/issues/22250))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1075/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-04-27T02:05:33Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

wuxu92 added 2 commits December 11, 2023 15:24

try normalize dns target resource id to fix case issue

ebdfa95

use lowercase resource group name to fix acc tests

3645b4e

github-actions bot added service/dns size/XS labels Dec 11, 2023

stephybun requested changes Dec 11, 2023

View reviewed changes

github-actions bot added the waiting-response label Dec 11, 2023

inline normalize target resource id

01a3f2d

github-actions bot removed the waiting-response label Dec 12, 2023

stephybun requested changes Dec 12, 2023

View reviewed changes

github-actions bot added the waiting-response label Dec 12, 2023

add other possible resource id for target resource id

5e65d42

github-actions bot removed the waiting-response label Dec 18, 2023

stephybun requested changes Jan 22, 2024

View reviewed changes

stephybun added the bug label Jan 22, 2024

github-actions bot added the waiting-response label Jan 22, 2024

add todo comment for updating the id parser logic once the recaser wo…

1af4cc2

…rk is finished

github-actions bot removed the waiting-response label Jan 25, 2024

stephybun approved these changes Jan 25, 2024

View reviewed changes

stephybun merged commit 6b1e66a into hashicorp:main Jan 25, 2024
30 checks passed

github-actions bot added this to the v3.90.0 milestone Jan 25, 2024

stephybun added a commit that referenced this pull request Jan 26, 2024

Update for #24571 #22250 #24181 #18761 #24291

7518216

rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Jan 30, 2024

Update for hashicorp#24571 hashicorp#22250 hashicorp#24181 hashicorp#…

1e71de0

…18761 hashicorp#24291

github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_dns_cname_record`: try normalize `target_resource_id` with RecordTypeID before set to state #24181

`azurerm_dns_cname_record`: try normalize `target_resource_id` with RecordTypeID before set to state #24181

wuxu92 commented Dec 11, 2023 •

edited

stephybun Dec 11, 2023

wuxu92 Dec 12, 2023

stephybun Dec 12, 2023

wuxu92 Dec 12, 2023

jackofallops Dec 12, 2023

wuxu92 Dec 17, 2023

stephybun left a comment

stephybun Jan 22, 2024

wuxu92 Jan 23, 2024

stephybun Jan 25, 2024

tombuildsstuff commented Jan 24, 2024

stephybun left a comment

stephybun Jan 25, 2024

github-actions bot commented Apr 27, 2024

azurerm_dns_cname_record: try normalize target_resource_id with RecordTypeID before set to state #24181

azurerm_dns_cname_record: try normalize target_resource_id with RecordTypeID before set to state #24181

Conversation

wuxu92 commented Dec 11, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff commented Jan 24, 2024

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 27, 2024

`azurerm_dns_cname_record`: try normalize `target_resource_id` with RecordTypeID before set to state #24181

`azurerm_dns_cname_record`: try normalize `target_resource_id` with RecordTypeID before set to state #24181

wuxu92 commented Dec 11, 2023 •

edited