Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] azurerm_pim_active_role_assignment, azurerm_pim_eligible_role_assignment #24524

Merged
merged 10 commits into from Feb 29, 2024
Merged

[Bug Fix] azurerm_pim_active_role_assignment, azurerm_pim_eligible_role_assignment #24524

merged 10 commits into from Feb 29, 2024

Commits on Jan 17, 2024

  1. Fix PIM related issues 

    1. Replace the Instance API by Schedule API
2. Use the Schedule Request ID to get the Schedule Request not Schedule ID
3. Use cancel API to cancel the pending role assignment
    @xuzhang3
    xuzhang3 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c830a04 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. fix acctest

    @xuzhang3
    xuzhang3 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    790380b View commit details
    Browse the repository at this point in the history

  2. update filter

    @xuzhang3
    xuzhang3 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a7230cc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into fix/PIM_schedules

    @xuzhang3
    xuzhang3 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    67e6493 View commit details
    Browse the repository at this point in the history

  4. update vendor

    @xuzhang3
    xuzhang3 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    79e3e36 View commit details
    Browse the repository at this point in the history

  5. update test case

    @xuzhang3
    xuzhang3 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    1e41e89 View commit details
    Browse the repository at this point in the history

  6. update test case

    @xuzhang3
    xuzhang3 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c8c0d1c View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Merge branch 'main' into fix/PIM_schedules

    @manicminer
    manicminer committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b19404f View commit details
    Browse the repository at this point in the history

  2. go mod tidy && go mod vendor

    @manicminer
    manicminer committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    22475a3 View commit details
    Browse the repository at this point in the history

  3. linting, use switch statement instead of map lookup

    @manicminer
    manicminer committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    80b66ca View commit details
    Browse the repository at this point in the history