Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network - update virtual hub resources to use hashicorp/go-azure-sdk #25992

Merged
merged 4 commits into from
May 24, 2024
Merged

network - update virtual hub resources to use hashicorp/go-azure-sdk #25992

merged 4 commits into from
May 24, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented May 16, 2024 •
edited

Community Note

  • Please vote on this PR by adding a 馃憤 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Updates the following resources to use hashicorp/go-azure-sdk:

  • azurerm_network_interface_security_group_association
  • azurerm_virtual_hub_bgp_connection
  • azurerm_virtual_hub_connection
  • azurerm_virtual_hub_ip
  • azurerm_virtual_hub
  • azurerm_virtual_hub_route_table
  • azurerm_virtual_hub_route_table_route
  • azurerm_virtual_hub_security_partner_provider

Updates the following data sources to use hashicorp/go-azure-sdk:

  • azurerm_virtual_hub_connection
  • azurerm_virtual_hub
  • azurerm_virtual_hub_route_table

Testing

Tests are looking good, however as of last night some tests that didn't fail previously are failing with InternalServerError. These look to be transient.

@stephybun stephybun marked this pull request as draft May 16, 2024 13:25
@stephybun stephybun marked this pull request as ready for review May 21, 2024 09:11
@stephybun stephybun requested a review from a team May 21, 2024 09:11
jackofallops
jackofallops approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 馃悵

@stephybun stephybun merged commit 465ae72 into main May 24, 2024
30 checks passed
@stephybun stephybun deleted the r/update-more-network-resource-to-go-azure-sdk branch May 24, 2024 12:52
@github-actions github-actions bot added this to the v3.106.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
service/network size/XL
Projects
None yet
Milestone
v3.106.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephybun @jackofallops