-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_snapshot
- Add support for disk_access_id
#25996
azurerm_snapshot
- Add support for disk_access_id
#25996
Conversation
…ugs for disk_access_id
azurerm_snapshot
- Add support for disk_access_id
azurerm_snapshot
- Add support for disk_access_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @rizkybiz
Thanks for this PR, I've taken a look through and left some comments inline, but on the whole this is looking pretty good - if we can fix those up and the tests pass then this otherwise LGTM 👍
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @rizkybiz
This functionality has been released in v3.105.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Community Note
Description
Added
disk_access_id
to theazurerm_snapshot
resource. The parameterdisk_access_id
is required if setting the parameternetwork_access_policy
toAllowPrivate
.PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.