azurerm_route_map - Make rule parameters optional when type is Drop

[oWretch]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Route Map rule do not support parameters when the action type is Drop. With the current provider, the parameter block must be supplied regardless of the action type. This means either having to create an empty parameter block for Drop which causes perpetual diffs, or create a parameter block with one of the parameters as an empty list to prevent the diff.

This PR makes the parameter block optional, and validates it is provided for non-Drop types during the plan

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_route_map - make property optional when the action type is Drop [azurerm_route_map - Make rule parameters optional when type is Drop #26003]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

[catriona-m]

Hi @oWretch, thanks for submitting this. This is looking good so far, but it would be good if we could include this case in the tests. Thanks!

[oWretch]

Thanks @catriona-m. I've added the drop rule to the test suite.

[stephybun]

Thanks @oWretch LGTM 👍