New Resource: `azurerm_dev_center_dev_box_definition` #26307

neil-yechenwei · 2024-06-12T09:02:00Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support new resource azurerm_dev_center_dev_box_definition.

API Reference: https://github.com/Azure/azure-rest-api-specs/blob/259fe9abaed3b55b600dc82d79323f046501e87f/specification/devcenter/resource-manager/Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L2342

Overview: https://learn.microsoft.com/en-gb/azure/dev-box/overview-what-is-microsoft-dev-box

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccDevCenterDevBoxDefinition_basic (1124.40s)
--- PASS: TestAccDevCenterDevBoxDefinition_requiresImport (1010.20s)
--- PASS: TestAccDevCenterDevBoxDefinition_update (1310.47s)
--- PASS: TestAccDevCenterDevBoxDefinition_complete (1092.29s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_dev_center_dev_box_definition

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

ms-zhenhua

Hi @neil-yechenwei ,

Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

internal/services/devcenter/dev_center_dev_box_definition_resource.go

neil-yechenwei · 2024-06-24T01:25:57Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look.

neil-yechenwei · 2024-06-24T02:09:21Z

@ms-zhenhua , below is the test result I just now triggered.

ms-zhenhua · 2024-06-24T07:16:07Z

@neil-yechenwei, thank you for your updates. LGTM~

stephybun · 2024-07-08T10:15:25Z

internal/services/devcenter/dev_center_dev_box_definition_resource_test.go

+
+	resp, err := clients.DevCenter.V20230401.DevBoxDefinitions.Get(ctx, *id)
+	if err != nil {
+		return nil, fmt.Errorf("reading %s: %+v", *id, err)


Suggested change

return nil, fmt.Errorf("reading %s: %+v", *id, err)

return nil, fmt.Errorf("retrieving %s: %+v", *id, err)

stephybun · 2024-07-08T10:15:34Z

internal/services/devcenter/dev_center_dev_box_definition_resource_test.go

+		return nil, fmt.Errorf("reading %s: %+v", *id, err)
+	}
+
+	return utils.Bool(resp.Model != nil), nil


Suggested change

return utils.Bool(resp.Model != nil), nil

return pointer.To(resp.Model != nil), nil

stephybun · 2024-07-08T10:18:33Z

website/docs/r/dev_center_dev_box_definition.html.markdown

+
+* `dev_center_id` - (Required) The ID of the associated Dev Center. Changing this forces a new resource to be created.
+
+* `image_reference_id` - (Required) The ID of the image for Dev Center Dev Box Definition.


Suggested change

* `image_reference_id` - (Required) The ID of the image for Dev Center Dev Box Definition.

* `image_reference_id` - (Required) The ID of the image for the Dev Center Dev Box Definition.

stephybun · 2024-07-08T10:18:45Z

website/docs/r/dev_center_dev_box_definition.html.markdown

+
+* `image_reference_id` - (Required) The ID of the image for Dev Center Dev Box Definition.
+
+* `sku_name` - (Required) The name of the SKU for Dev Center Dev Box Definition.


Suggested change

* `sku_name` - (Required) The name of the SKU for Dev Center Dev Box Definition.

* `sku_name` - (Required) The name of the SKU for the Dev Center Dev Box Definition.

stephybun · 2024-07-08T10:19:52Z

website/docs/r/dev_center_dev_box_definition.html.markdown

+An existing Dev Center Dev Box Definition can be imported into Terraform using the `resource id`, e.g.
+
+```shell
+terraform import azurerm_dev_center_dev_box_definition.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.DevCenter/devcenters/dc1/devboxdefinitions/et1


Casing here?

Suggested change

terraform import azurerm_dev_center_dev_box_definition.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.DevCenter/devcenters/dc1/devboxdefinitions/et1

terraform import azurerm_dev_center_dev_box_definition.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.DevCenter/devCenters/dc1/devBoxDefinitions/et1

neil-yechenwei added 2 commits June 12, 2024 14:57

New Resource: azurerm_dev_center_dev_box_definition

ff3ca2e

update resource

22edb73

neil-yechenwei marked this pull request as draft June 12, 2024 09:02

github-actions bot added documentation service/dev-center size/XL labels Jun 12, 2024

neil-yechenwei added 2 commits June 12, 2024 17:28

update tags

6420cf1

update tc

63ac847

ms-zhenhua suggested changes Jun 19, 2024

View reviewed changes

github-actions bot added the waiting-response label Jun 19, 2024

update the update func

2042d76

github-actions bot removed the waiting-response label Jun 19, 2024

neil-yechenwei requested a review from ms-zhenhua June 19, 2024 06:43

github-actions bot added waiting-response and removed waiting-response labels Jun 19, 2024

remove tier

40d8eb8

github-actions bot removed the waiting-response label Jun 24, 2024

update sku

ce579a9

ms-zhenhua approved these changes Jun 24, 2024

View reviewed changes

neil-yechenwei marked this pull request as ready for review June 24, 2024 07:52

stephybun requested changes Jul 8, 2024

View reviewed changes

github-actions bot added the waiting-response label Jul 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_dev_center_dev_box_definition` #26307

New Resource: `azurerm_dev_center_dev_box_definition` #26307

neil-yechenwei commented Jun 12, 2024 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented Jun 24, 2024

neil-yechenwei commented Jun 24, 2024

ms-zhenhua commented Jun 24, 2024

stephybun Jul 8, 2024

stephybun Jul 8, 2024

stephybun Jul 8, 2024

stephybun Jul 8, 2024

stephybun Jul 8, 2024

	return nil, fmt.Errorf("reading %s: %+v", *id, err)
	return nil, fmt.Errorf("retrieving %s: %+v", *id, err)

	return utils.Bool(resp.Model != nil), nil
	return pointer.To(resp.Model != nil), nil


		* `dev_center_id` - (Required) The ID of the associated Dev Center. Changing this forces a new resource to be created.

		* `image_reference_id` - (Required) The ID of the image for Dev Center Dev Box Definition.


		* `image_reference_id` - (Required) The ID of the image for Dev Center Dev Box Definition.

		* `sku_name` - (Required) The name of the SKU for Dev Center Dev Box Definition.

	terraform import azurerm_dev_center_dev_box_definition.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.DevCenter/devcenters/dc1/devboxdefinitions/et1
	terraform import azurerm_dev_center_dev_box_definition.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/group1/providers/Microsoft.DevCenter/devCenters/dc1/devBoxDefinitions/et1

New Resource: azurerm_dev_center_dev_box_definition #26307

Are you sure you want to change the base?

New Resource: azurerm_dev_center_dev_box_definition #26307

Conversation

neil-yechenwei commented Jun 12, 2024 • edited Loading

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Jun 24, 2024

neil-yechenwei commented Jun 24, 2024

ms-zhenhua commented Jun 24, 2024

stephybun Jul 8, 2024

Choose a reason for hiding this comment

stephybun Jul 8, 2024

Choose a reason for hiding this comment

stephybun Jul 8, 2024

Choose a reason for hiding this comment

stephybun Jul 8, 2024

Choose a reason for hiding this comment

stephybun Jul 8, 2024

Choose a reason for hiding this comment

New Resource: `azurerm_dev_center_dev_box_definition` #26307

New Resource: `azurerm_dev_center_dev_box_definition` #26307

neil-yechenwei commented Jun 12, 2024 •

edited

Loading