Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5111 storage_account_network_rules #5153

Closed
wants to merge 1 commit into from

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Dec 13, 2019

Help to fix issue #5111
I think the storage_account_network_rules_test doesn't pass before, now passed

@tombuildsstuff
Copy link
Member

hi @yupwei68

Thanks for this PR.

Taking a look through whilst this looks to update the validation here to allow CIDR blocks, it appears that the API also accepts IP Addresses, since the tests are passing in master:

Screenshot 2019-12-17 at 21 45 08

I'm going to suggest that we instead match the validation for the new azurerm_storage_account_network_rules resource with the existing validation in the azurerm_storage_account resource; as such whilst I'd like to thank you for this contribution I'm going to close this PR in favour of #5201 which includes these changes.

Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants