Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Analysis Services IPv4 rule name casing issue fix #6774

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented May 5, 2020

I needed to change the hash function of an ipv4_firewall_rule to a custom one in order to prevent situations like the following:

azurerm_analysis_services_server.analysis_services will be updated in-place
  ~ resource "azurerm_analysis_services_server" "analysis_services" {
        admin_users               = []
        enable_power_bi_service   = true
        id                        = "/subscriptions/dc8fbfc0-2769-421c-921e-f0dae437fa79/resourceGroups/dl4-analysis-services-rg/providers/Microsoft.AnalysisServices/servers/myanalysisservices"
        location                  = "northeurope"
        name                      = "myanalysisservices"
        querypool_connection_mode = "All"
        resource_group_name       = "dl4-analysis-services-rg"
        server_full_name          = "asazure://northeurope.asazure.windows.net/myanalysisservices"
        sku                       = "S1"
        tags                      = {}
      + ipv4_firewall_rule {
          + name        = "DWHMGMT-QDM-VM"
          + range_end   = "13.74.177.213"
          + range_start = "13.74.177.213"
        }
      - ipv4_firewall_rule {
          - name        = "dwhmgmt-qdm-vm" -> null
          - range_end   = "13.74.177.213" -> null
          - range_start = "13.74.177.213" -> null
        }
    }

When applying the changes above nothing really changed on server side as it didn't see a difference in the name.

@tombuildsstuff suggested to try to convert it to a list instead but I already switched the rules to Set a few weeks ago because the order sometimes randomly changed. That's why I think a Set is the best option here.

@ghost ghost added the size/XS label May 5, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r0bnet
LGTM 👍 Will fire off the acctests now.

Ste

@jackofallops
Copy link
Member

Tests pass:
image

@jackofallops jackofallops merged commit 56f2f17 into hashicorp:master May 6, 2020
jackofallops added a commit that referenced this pull request May 6, 2020
@r0bnet r0bnet deleted the analysis-services-server-ipv4-rule-name-case-fix branch May 28, 2020 13:23
@ghost
Copy link

ghost commented Jun 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants