Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_policy_remediation - Support resource_discovery_mode #7914

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #6658

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Member

@ArcturusZhang looks like the tests are failing here:

------- Stdout: -------
=== RUN   TestAccAzureRMPolicyRemediation_atSubscriptionWithDiscoveryMode
=== PAUSE TestAccAzureRMPolicyRemediation_atSubscriptionWithDiscoveryMode
=== CONT  TestAccAzureRMPolicyRemediation_atSubscriptionWithDiscoveryMode
TestAccAzureRMPolicyRemediation_atSubscriptionWithDiscoveryMode: testing.go:745: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: errors during apply: deleting Policy Remediation "acctestremediation-7tx3v" (Scope "/subscriptions/*******"): policyinsights.RemediationsClient#DeleteAtSubscription: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidDeleteRemediationRequest" Message="The request to delete remediation 'acctestremediation-7tx3v' is invalid. The remediation must be in a terminal provisioning state (Succeeded, Canceled, Failed) before it can be deleted."

@ArcturusZhang
Copy link
Contributor Author

Oops, I will take a look

@tombuildsstuff tombuildsstuff added this to the v2.26.0 milestone Aug 27, 2020
@ArcturusZhang
Copy link
Contributor Author

Temporarily close this since I could not resolve this test failure without the help from service team...

@ghost
Copy link

ghost commented Sep 4, 2020

This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.26.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ResourceDiscoveryMode in azurerm_policy_remediation
2 participants