Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azurerm_policy_set_definition - Fix #8663 #8668

Merged
merged 5 commits into from
Oct 8, 2020
Merged

Update azurerm_policy_set_definition - Fix #8663 #8668

merged 5 commits into from
Oct 8, 2020

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #8663

@ghost ghost added the size/M label Sep 29, 2020
This was referenced Sep 29, 2020
Closed
Merged
jackofallops
jackofallops requested changes Sep 29, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ArcturusZhang
Thanks for this PR, just one comment below but otherwise LGTM 👍

azurerm/internal/services/policy/policy_set_definition_resource.go Outdated Show resolved Hide resolved
@ArcturusZhang
Copy link
Contributor Author

Hi @jackofallops I have made some changes, please have a look

tombuildsstuff
tombuildsstuff previously requested changes Sep 30, 2020
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ArcturusZhang

Thanks for pushing those changes - taking a look through there's another thing I've spotted here but if we can fix that up then this otherwise LGTM 👍

Thanks!

azurerm/internal/services/policy/tests/policy_set_definition_resource_test.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v2.30.0 milestone Sep 30, 2020
@jackofallops jackofallops modified the milestones: v2.30.0, v2.31.0 Oct 1, 2020
@jackofallops
Copy link
Member

Tests passing (2 failures are existing / unrelated)
image

@jackofallops jackofallops merged commit d4dca1b into hashicorp:master Oct 8, 2020
jackofallops added a commit that referenced this pull request Oct 8, 2020
@jackofallops
Update CHANGELOG.md for #8668
b06271f
@ghost
Copy link

ghost commented Oct 8, 2020

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

@ArcturusZhang ArcturusZhang deleted the fix-policy-set-definition-issue branch October 22, 2020 02:15
@ghost
Copy link

ghost commented Nov 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

Assignees

@ArcturusZhang ArcturusZhang

Labels
bug service/policy size/M
Projects
None yet
Milestone
v2.31.0
Development

Successfully merging this pull request may close these issues.

New issues introduced by #8270
3 participants
@ArcturusZhang @jackofallops @tombuildsstuff