Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating provider-defined functions to use named parameters #227

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Mar 20, 2024

With the update to the plugin framework that now requires all provider-defined function parameters are named, this repo needs to be updated to add parameter names throughout.

Changes were evaluated by:

  • Building a local Terraform binary from v1.8.0-beta1
  • Temporarily switching all tfversion.SkipBelow(tfversion.Version1_8_0) to tfversion.SkipBelow(tfversion.Version1_7_0)
  • Temporarily updating go.mod to use the branch of the plugin framework containing the changes requiring all function parameters are named.
  • Running the tests

During the execution of the tests, it was discovered that TestNumberFunction_known was failing. This was raised as an issue on the Terraform core repo - Planned value does not match config value for number. A note was made within the tests to refer to this issue:

	// Using 9223372036854775808, the smallest number that can't be represented as an int64,
	// results in an Terraform error where [Planned value does not match config value for number].
	// A value of 9223372036854775809 is used for the meanwhile.
	//
	// [Planned value does not match config value for number]: https://github.com/hashicorp/terraform/issues/34866

Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bendbennett bendbennett merged commit 26c9879 into main Mar 20, 2024
64 checks passed
@bendbennett bendbennett deleted the bendbennett/pdf-enforce-param-name branch March 20, 2024 15:43
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants