Bump Go version to 1.16.15, prepare 3.2.2 release #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: golang/go#51127 Reference: #157 Reference: #188 Updates the testing and release processes to the latest 1.16.x version, which resolves a longstanding Go resolver issue with responses greater than 512 bytes. Verifies by enabling a previously skipped acceptance test. Also adds CHANGELOG entries for upstream module updates which are bundled with this provider release, which may fix specific EDNS handling issues.
detro
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
LGTM
One observation that I don't think we can't do anything about: the tests in this provider are "risky". The fact that they execute real DNS resolutions has the chance to fail if thing change or temporary outages occur. SCRAP THAT!
It would be awesome if we could spawn a DNS server.
Curious, I dug into how the automation is wired up, and saw that we do exactly that: spawn local DNS servers to simulate various scenarios and then run the tests against it.
Kudos and, once more, LGTM! 👩🍳 💋
|
Yeah, ideally, we'd implement our own DNS server in Go for the "regular" DNS query testing if/when those data sources allow lookup via custom resolver, but the effort/benefit ratio hasn't made it worth it in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: golang/go#51127
Closes #157
Reference: #188 (I'd like to verify this is fixed after release, rather than close immediately)
Updates the testing and release processes to the latest 1.16.x version, which resolves a longstanding Go resolver issue with responses greater than 512 bytes. Verifies by enabling a previously skipped acceptance test.
Also adds CHANGELOG entries for upstream module updates which are bundled with this provider release, which may fix specific EDNS handling issues.