Skip to content

Commit

Permalink
Support ability to create "non-custom" services (#6604) (#4789)
Browse files Browse the repository at this point in the history
* Support ability to create "non-custom" services

Allow users to create various Service Monitoring services: App Engine,
Cloud Run, etc.

hashicorp/terraform-provider-google#11935

* Specify BasicService is immutable

* Responding to review comments.

* Add test; make service_id required

* labels still need input: true; remove encoder

* Correct typo

* Ignore service fields in SLO import test

* Correct test

* Make id_format and import_format the same

* Remove custom code

* Correct test typo

* service is actually input-only

* Add resource test

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician committed Oct 14, 2022
1 parent a67a0bb commit 6e8c618
Show file tree
Hide file tree
Showing 8 changed files with 973 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .changelog/6604.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
google_monitoring_generic_service
```
5 changes: 3 additions & 2 deletions google-beta/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -988,9 +988,9 @@ func Provider() *schema.Provider {
return provider
}

// Generated resources: 270
// Generated resources: 271
// Generated IAM resources: 177
// Total generated resources: 447
// Total generated resources: 448
func ResourceMap() map[string]*schema.Resource {
resourceMap, _ := ResourceMapWithErrors()
return resourceMap
Expand Down Expand Up @@ -1346,6 +1346,7 @@ func ResourceMapWithErrors() (map[string]*schema.Resource, error) {
"google_monitoring_group": resourceMonitoringGroup(),
"google_monitoring_notification_channel": resourceMonitoringNotificationChannel(),
"google_monitoring_custom_service": resourceMonitoringService(),
"google_monitoring_service": resourceMonitoringGenericService(),
"google_monitoring_slo": resourceMonitoringSlo(),
"google_monitoring_uptime_check_config": resourceMonitoringUptimeCheckConfig(),
"google_monitoring_metric_descriptor": resourceMonitoringMetricDescriptor(),
Expand Down

0 comments on commit 6e8c618

Please sign in to comment.