Skip to content

Commit

Permalink
dns: ignore case changes for DS records (#4769) (#3236)
Browse files Browse the repository at this point in the history
DS records need case change suppression as with "MX" records.

Closes hashicorp/terraform-provider-google#9093

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician committed May 6, 2021
1 parent abc6481 commit b8ea43e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .changelog/4769.txt
@@ -0,0 +1,3 @@
```release-note:bug
dns: suppress spurious diffs due to case changes in DS records
```
2 changes: 1 addition & 1 deletion google-beta/resource_dataflow_flex_template_job_test.go
Expand Up @@ -8,7 +8,7 @@ import (

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
compute "google.golang.org/api/compute/v1"
"google.golang.org/api/compute/v1"
)

func TestAccDataflowFlexTemplateJob_basic(t *testing.T) {
Expand Down
3 changes: 2 additions & 1 deletion google-beta/resource_dataproc_cluster_test.go
Expand Up @@ -13,8 +13,9 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

dataproc "google.golang.org/api/dataproc/v1beta2"
"google.golang.org/api/googleapi"

dataproc "google.golang.org/api/dataproc/v1beta2"
)

func TestDataprocExtractInitTimeout(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion google-beta/resource_dns_resource_dns_record_set.go
Expand Up @@ -41,7 +41,7 @@ func rrdatasDnsDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
case "AAAA":
// parse ipv6 to a key from one list
return net.ParseIP(record).String()
case "MX":
case "MX", "DS":
return strings.ToLower(record)
case "TXT":
return strings.ToLower(strings.Trim(record, `"`))
Expand Down

0 comments on commit b8ea43e

Please sign in to comment.