Make iap field computed
#2342
Merged
Make iap field computed
#2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
the
modular-magician
added a commit
to modular-magician/terraform-provider-google-beta
that referenced
this pull request
Dec 14, 2023
…ll examples cross-project-friendly (#9637) * Fix "Pubsub Subscription Different Project" example PR hashicorp#2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR hashicorp#2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
added a commit
that referenced
this pull request
Dec 14, 2023
…ll examples cross-project-friendly (#9637) (#6758) * Fix "Pubsub Subscription Different Project" example PR #2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR #2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an internal user that wound up in a state where
iapwas returning from the API, but Terraform assumed the user wanted to delete the block. Setting it to computed should fix this without disrupting other cases.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3814