Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send empty privateVisibilityConfig network array #2380

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#6973

The api only removes the privateVisibilityConfig block when sending an empty networks array like so:

  "privateVisibilityConfig": {
    "networks": []
  }

Added a custom expander to do this. Using a custom expander on the parent field removed the expanders for the subfields, so I included the subfield expanders in the template. This makes the custom expander looks excessive, but generates small downstream diffs.

Release Note Template for Downstream PRs (will be copied)

dns: fixed an issue where `google_dns_managed_zone` would not remove `private_visibility_config` on updates

Derived from GoogleCloudPlatform/magic-modules#3865

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Aug 13, 2020
@modular-magician modular-magician merged commit 827d31e into hashicorp:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant