Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

products/container: Add datapath provider field #2492

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests. (I think I might have not done all the changes required though as I couldn't see changes in the generated terraform)
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). (I can't see any GKE examples in this directory, are they maybe somewhere else?)
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Add support for `datapath_provider` to `google_container_cluster`

Fixes hashicorp/terraform-provider-google#7207

My apologies in advance as I feel I haven't found where to do all the changes necessary. I would appreciate a hint where else changes might be necessary.

Derived from GoogleCloudPlatform/magic-modules#3956

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit d0e7f2f into hashicorp:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant