Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replacement_method to IGM and RIGM update_policy #2756

Conversation

modular-magician
Copy link
Collaborator

This PR adds a replacement_method argument to the update_policy stanza of google_compute_instance_group_manager and google_compute_region_instance_group_manager resources. This allows preserving instance names during an upgrade.

Fixes hashicorp/terraform-provider-google#7417

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `replacement_method` field to `update_policy` block of `google_compute_instance_group_manager`
compute: added `replacement_method` field to `update_policy` block of `google_compute_region_instance_group_manager`

Derived from GoogleCloudPlatform/magic-modules#4258

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/m labels Dec 2, 2020
@modular-magician modular-magician merged commit 50f26d8 into hashicorp:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant