Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app_engine_service_network_settings resource #3371

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#7866

Reference: https://cloud.google.com/appengine/docs/admin-api/reference/rest/v1/apps.services#networksettings

I'm not sure whether I need to write more tests for this resource, on top of the generated example one - some other resources seem to only have the generated example test and I couldn't really see a distinction between those had extra tests and those that didn't.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_app_engine_service_network_settings`

Derived from GoogleCloudPlatform/magic-modules#4810

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 5bd0be9 into hashicorp:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant