Move files to the sweeper and envvar packages #5824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes are in the files
In this PR,
gcp_sweeper.go
fromacctest
package to thesweeper
packageprovider_test_utils.go
in theacctest
package to the packageenvvar
The reason to introduce the new packages sweep and envvar is to avoid the import circle.
The
testAccProvider
will be moved to the acctest package from the google package later.If the file
gcp_sweeper.go
and the env variables are still in theacctest
package, the sweeper file in the specific service package imports theacctest
package to add the sweeper to the sweepers map. Theacctest
package imports theprovider
package to initialize the testAccProvider. Theprovider
package imports the service package. Then the import circle is formed.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8198