Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the networksecurity p4sa is permissioned in tests #5830

Conversation

modular-magician
Copy link
Collaborator

Implements the guidance from https://cloud.google.com/secure-web-proxy/docs/enable-tls-inspection#create-service-account. This could technically be done at environment bootstrap time, but the identity resource is idempotent and the permission is tied to the specific pool, so let's just do it inline.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#8222

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit d7f349b into hashicorp:main Jun 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant