Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create region security policies rules #6086

Conversation

modular-magician
Copy link
Collaborator

Fixes:
hashicorp/terraform-provider-google#15319

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_security_policy_rule`
compute: added support for `user_defined_fields` to `google_compute_region_security_policy`

Derived from GoogleCloudPlatform/magic-modules#8477

* creating first version of region security policy and adding ddos protection config

* adding rules field in region security policy

* creating resource network_edge_security_service and their scenarios of test

* adding patch operation and fixing id, import_format and self_link

* added fields in the region_security_policy, and fixed the scenario tests for network_edge_security_service

* removed duplicated field for region_security_policy

* adding ddos_protection_config field in region_security_policy

* cleanups

* adding self_link field back and removing uncessary fields

* adding docs for ddosProtection

* making new resources only availabe in beta downstream

* fixing eof

* adding region security policy rule and basic scenario

* code experiments cleanups

* adding preconfiguredWafConfig object and some inner fields in region security policy rule

* adding mapping for network_match object in region security policy rule

* adding rateLimitOptions mapping

* adding ruleNumber field to region security policy

* adding basic update for region security policy rule

* adding network_match and preconfigured_waf scenarios for region sec policy rules

* wip - adding user_defined_fields in region security policy

* fixing yaml linter issues

* fixing review comments

* removing validate_only field

* fixing comments in region_security_policy_rule test

* fixing userDefinedFields and adding tests for regionSecPolicyRule

* adding user_defined_fields update test for regionSecPolicy

* removing rule_number from regionSecPolicyRule

* removing preconfiguredWaf from regionSecPolicyRule because it is not finished yet

* removing rateLimitOptions from RegionSecPolicyRule because it is not finished yet

* small cleanups

* fixing yamllint issues on the worked resources

* prevent that netwrokt_match test fails due paralellism

* adding new test for multiple rules

* fixing code review comments

* removing harcoded project from tests

* moving network_edge_security_service basic test to another region

* fixing code review issues

* fixing import cycle issue in downstream repo

* updating with upstream and change regions

---------

Co-authored-by: diogoEsteves <diogoesteves@ciandt.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 317ea0b into hashicorp:main Aug 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant