Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Cloud SQL PSC connectivity management support #6119

Conversation

modular-magician
Copy link
Collaborator

Introducing Cloud SQL instance PSC connectivity management support on Terraform. This change is introducing following

  • psc_config - parameter for updating psc configuration settings.
    • psc_enable - whether psc connectivity is enabled for this instance or not.
    • allowed_consumer_projects - list of consumer projects that are allow-listed for PSC connections to this instance.
  • psc_service_attachment_link - the link to service attachment of PSC instance.
  • dns_name - the dns name of the instance.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added `psc_config` , `psc_service_attachment_link`, and `dns_name` fields to `google_sql_database_instance`

Derived from GoogleCloudPlatform/magic-modules#8580

* Added PSC connectivity support in Cloud SQL Terraform

* Added functional tests for PSC support in Cloud SQL

* Added test fixes and compilation fixes

* Fixed test cases

* Upgraded google.golang.org/api to v0.135.0

* Added documentation for PSC configuration support

* Fixed go.sum file

* Fixed go mod and go sum file

* Modified test case

* Fixed test case failure

* Added org_id in google_project resource

* Introduces changes for creating project

* Changes instance regions

* Added import id prefix

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a6a719e into hashicorp:main Aug 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant