Comment out PF provider config test that's affected by ADCs in our CI #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (#9034) Signed-off-by: Modular Magician <magic-modules@google.com>
zli82016
pushed a commit
that referenced
this pull request
Jun 10, 2024
… (#9034) (#6326) Signed-off-by: Modular Magician <magic-modules@google.com>
zli82016
added a commit
that referenced
this pull request
Jun 11, 2024
* Adds support for Soft Delete feature, which allows setting soft delete policy on 'google_storage_bucket' resource. (#10171) (#7119) [upstream:3b9c61bd50c271e769a6cb81dbd28d5ba7512c15] Signed-off-by: Modular Magician <magic-modules@google.com> * Comment out PF provider config test that's affected by ADCs in our CI (#9034) (#6326) Signed-off-by: Modular Magician <magic-modules@google.com> * fix TestAccFirebaseWebApp_firebaseWebAppFull * Upgrade go api client to 0.167 * Fix TestAccFirebaseWebApp_firebaseWebAppBasicExample * Add 4.84.1 changelog * Update 4.85 CHANGELOG --------- Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: The Magician <magic-modules@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test passes but relies on an environment without ADCs, and it's not possible to remove ADCs in the CI
This issue was not picked up by checks on the PR introducing the test: GoogleCloudPlatform/magic-modules#8943
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9034