Add check for Environment proto field before accessing in Dataflow provider #6999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovider (#10016) [upstream:6aba2a9bda474112d1d59bf0b8e7b627afb2ee7a] Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra check to the Dataflow provider when accessing job proto fields; an edge case existed where the
Environmentproto field is nil, causing a nil-pointer exception when accessing sub-fields rather than an error that can be returned up the call stack. Checking for existence and bubbling an error up should eliminate that issue.Validated the code change is propagated to the generated repos following https://googlecloudplatform.github.io/magic-modules/get-started/generate-providers/, also passed linting + unit tests + dataflow acceptance tests
Fixes hashicorp/terraform-provider-google#17046
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10016