Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type field to DNS authorization reosurce #7036

Conversation

modular-magician
Copy link
Collaborator

This PR:

  • Added type, a new optional field, to Certificate Manager DNS authorization resource.
  • Added an example for creating regional DNS authorization resource (as it's now supported + in public review)
  • Added an example for creating regional certificate manager certificate with regional DNS auth.

Tests that I ran:

make testacc TEST=./google/services/certificatemanager TESTARGS='-run=TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationRegionalExample'

make testacc TEST=./google/services/certificatemanager TESTARGS='-run=TestAccCertificateManagerCertificate_certificateManagerGoogleManagedRegionalCertificateDnsAuthExample'

Release Note Template for Downstream PRs (will be copied)

certificatemanager: added `type` field to `google_certificate_manager_dns_authorization` resource

Derived from GoogleCloudPlatform/magic-modules#10030

* Add type field to DNS authorization reosurce

* Add an example for regional DNS authorization

* Add an example for regional certs using regional DNS auth

* Fix lint errors

* Fix typo in the enum values

* Add type field in regional dns auth example

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>

[upstream:0ac8f5283f99aca69ac1821ecbc67200d45b0390]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 99a8f0b into hashicorp:main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant