Add sleeps to IAP tests. Need to wait for IAM permissions (#5188) (#1…

…0070)

* Add sleeps to IAP tests. Need to wait for IAM permissions to propagate on new account

* Fix typo

Signed-off-by: Modular Magician <magic-modules@google.com>

.changelog/5188.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

google/iam_iap_tunnel_generated_test.go

@@ -33,6 +33,10 @@ func TestAccIapTunnelIamBindingGenerated(t *testing.T) {
 	vcrTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"random": {},
+			"time":   {},
+		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccIapTunnelIamBinding_basicGenerated(context),
@@ -69,6 +73,10 @@ func TestAccIapTunnelIamMemberGenerated(t *testing.T) {
 	vcrTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"random": {},
+			"time":   {},
+		},
 		Steps: []resource.TestStep{
 			{
 				// Test Iam Member creation (no update for member, no need to test)
@@ -96,6 +104,10 @@ func TestAccIapTunnelIamPolicyGenerated(t *testing.T) {
 	vcrTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"random": {},
+			"time":   {},
+		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccIapTunnelIamPolicy_basicGenerated(context),
@@ -127,9 +139,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 resource "google_iap_tunnel_iam_member" "foo" {
@@ -148,9 +169,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 data "google_iam_policy" "foo" {
@@ -175,9 +205,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 data "google_iam_policy" "foo" {
@@ -198,9 +237,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 resource "google_iap_tunnel_iam_binding" "foo" {
@@ -219,9 +267,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 resource "google_iap_tunnel_iam_binding" "foo" {

google/iam_iap_web_generated_test.go

@@ -33,6 +33,10 @@ func TestAccIapWebIamBindingGenerated(t *testing.T) {
 	vcrTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"random": {},
+			"time":   {},
+		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccIapWebIamBinding_basicGenerated(context),
@@ -69,6 +73,10 @@ func TestAccIapWebIamMemberGenerated(t *testing.T) {
 	vcrTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"random": {},
+			"time":   {},
+		},
 		Steps: []resource.TestStep{
 			{
 				// Test Iam Member creation (no update for member, no need to test)
@@ -96,6 +104,10 @@ func TestAccIapWebIamPolicyGenerated(t *testing.T) {
 	vcrTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"random": {},
+			"time":   {},
+		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccIapWebIamPolicy_basicGenerated(context),
@@ -127,9 +139,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 resource "google_iap_web_iam_member" "foo" {
@@ -148,9 +169,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 data "google_iam_policy" "foo" {
@@ -175,9 +205,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 data "google_iam_policy" "foo" {
@@ -198,9 +237,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 resource "google_iap_web_iam_binding" "foo" {
@@ -219,9 +267,18 @@ resource "google_project" "project" {
   org_id     = "%{org_id}"
 }
 
+resource "time_sleep" "wait_60_seconds" {
+  depends_on = [google_project.project]
+
+  create_duration = "60s"
+}
+
 resource "google_project_service" "project_service" {
   project = google_project.project.project_id
   service = "iap.googleapis.com"
+
+  # Needed for CI tests for permissions to propagate, should not be needed for actual usage
+  depends_on = [time_sleep.wait_60_seconds]
 }
 
 resource "google_iap_web_iam_binding" "foo" {