Fix crash caused by nil value in BigQuery Table (#10319) (#17721)

[upstream:bfe6e935a2ecb1d1fc347b9aff11392d692be367] Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Mar 28, 2024 · 6cd9e80 · 6cd9e80
1 parent b848632
commit 6cd9e80
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.changelog/10319.txt b/.changelog/10319.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+bigquery: fixed a crash when `google_bigquery_table` had a `primary_key.columns` entry set to `""`
+```
diff --git a/google/services/bigquery/resource_bigquery_table.go b/google/services/bigquery/resource_bigquery_table.go
@@ -2357,6 +2357,11 @@ func expandPrimaryKey(configured interface{}) *bigquery.TableConstraintsPrimaryK
 
 	columns := []string{}
 	for _, rawColumn := range raw["columns"].([]interface{}) {
+		if rawColumn == nil {
+			// Terraform reads "" as nil, which ends up crashing when we cast below
+			// sending "" to the API triggers a 400, which is okay.
+			rawColumn = ""
+		}
 		columns = append(columns, rawColumn.(string))
 	}
 	if len(columns) > 0 {